Hi Christophe, On Thu, 2024-02-29 at 18:39 +0100, Christophe Lyon wrote: > On Thu, 29 Feb 2024 at 12:00, Mark Wielaard <m...@klomp.org> wrote: > > That python script works across gcc/binutils/gdb: > > https://sourceware.org/cgit/builder/tree/builder/containers/autoregen.py > > > > It is installed into a container file that has the exact autoconf and > > automake version needed to regenerate the autotool files: > > https://sourceware.org/cgit/builder/tree/builder/containers/Containerfile-autotools > > > > And it was indeed done this way because that way the files are > > regenerated in a reproducible way. Which wasn't the case when using > > --enable-maintainer-mode (and autoreconfig also doesn't work). > > I see. So it is possibly incomplete, in the sense that it may lack > some of the steps that maintainer-mode would perform? > For instance, gas for aarch64 has some *opcodes*.c files that need > regenerating before committing. The regeneration step is enabled in > maintainer-mode, so I guess the autoregen bots on Sourceware would > miss a problem with these files?
Yes, it is certainly incomplete. But it is done this way because it is my understanding that even the gcc release maintainers do the automake/autoconf invocations by hand instead of running with configure --enable-maintainer-mode. Note that another part that isn't caught at the moment are the regeneration of the opt.urls files. There is a patch for that pending: https://inbox.sourceware.org/buildbot/20231215005908.gc12...@gnu.wildebeest.org/ But that is waiting for the actual opt.urls to be regenerated correctly first: https://inbox.sourceware.org/gcc-patches/20240224174258.gd1...@gnu.wildebeest.org/ Ping David? It would be nice to have all these "regeneration targets" in one script that could be used by both the pre-commit and post-commit checkers. Cheers, Mark
