Hi Martin, On Mon, Nov 06, 2023 at 06:04:48PM +0100, Martin Jambor wrote: > I have inherited Martin Liška's buildbot script that checks that all > sorts of autotools generated files, mainly configure scripts, were > re-generated correctly when appropriate. While the checks are hopefully > useful, they report issues surprisingly often and reporting them feels > especially unproductive.
Cool! A small python script cannot replace him of course. But it is nice to get a small virtual mliska :) > Could such checks be added to our server side push hooks so that commits > introducing these breakages would get refused automatically. While the > check might be a bit expensive, it only needs to be run on files > touching the generated files and/or the files these are generated from. So this doesn't just need that script, but also an execution environment that contains the right versions of the autotools. We could install those of course, but running them from a git hook on checkin indeed seems a little expensive. Creating a container with the script and the right versions of all tools might be the best thing. Then the script can be run from a cron job or buildbot. Or even by someone hacking on the build/configure scripts to make sure they are generating with the right tools. builder.sourceware.org already contains various of such containers: https://sourceware.org/cgit/builder/tree/builder/containers https://sourceware.org/cgit/builder/tree/README_containers Friday is Sourceware Open Office hour (#overseers on irc.libera.chat at 18:00 UTC). We could hack something together then and see how to hook it up. Cheers, Mark
