> Also, I think convert_memory_address ought to have a
    >   gcc_assert (GET_MODE (x) == to_mode);
    > in the #ifndef case.

    Interesting, I put this assertion in my code and I now cannot
    bootstrap on HPPA.  Looking at the HPPA builds (where
    POINTERS_EXTEND_UNSIGNED if not defined) I see the assertion fail
    because I enter convert_memory_address with to_mode set to SImode and
    x set to '(const_int 0 [0x0])'.

This is fine, but not a case I thought about when I suggested the above.

The correct is
        gcc_assert (GET_MODE (x) == to_mode || GET_MODE (x) == VOIDmode);

Sorry!

Reply via email to