On 10/15/14 11:54, Ilya Enkovich wrote:
Thanks for review! I see no more patches not reviewed at all. I see
4 more patches requiring approve before I can start a merge.
Two of them are parts of split #14 (Passes): #14.3 (Helper functions)
and #14.16 (Reduce bounds lifetime)
These are fine. We can revisit LCM/anticipated in the future for the
bounds lifetime reduction.
There is also #32 (hooks for i386 target). It has concern about TBAA
which I believe is not a problem in my case because accesses using
different types are not mixed.
OK. That was the only pending issue with that patch, so it's good to go
as well.
The final one is #33 (MPX ABI). I still see fail on one benchmark but
I don't feel ICE in LRA should prevent patch from been committed.
Assuming it doesn't fail unless you've turned on MPX, that seems
reasonable at this stage. Obviously we'd like to get that fixed during
the general bugfixing phase.
As I discussed with Areg, I wanted this stuff to wait until the Darwin
port had settled a bit after the recent problems. While Darwin isn't
happy yet, I think the remaining problems are manageable and isolated to
the i686 code generator. So if you could bootstrap Darwin 64 bit as a
sanity test along with a final bootstrap & regression test on x86_64
linux, then I think we're good to go.
jeff
