On Tue, Sep 30, 2014 at 10:03:05AM -0700, H.J. Lu wrote: > On Tue, Sep 30, 2014 at 9:47 AM, Evgeny Stupachenko <evstu...@gmail.com> > wrote: > > Hi, > > > > Patch resubmitted from > > https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01400.html > > > > The patch fix PR62128 and "gcc.target/i386/pr52252-atom.c" in > > core-avx2 make check. > > The test in pr62128 is exactly TEST 22 from > > gcc.dg/torture/vshuf-v32qi.c. It will check if the pattern is correct > > or not. > > The patch developed similar to define_insn_and_split > > "*avx_vperm_broadcast_<mode>". > > The patch passed x86 bootstrap and make check (+2 new passes for > > -march=core-avx2). > > Is it ok? > > > > Evgeny > > > > ChangeLog: > > > > 2014-09-30 Evgeny Stupachenko <evstu...@gmail.com> > > > > * config/i386/sse.md (avx2_palignrv4di): New. > > * config/i386/sse.md (avx2_rotate<mode>_perm): New. > > Please mention PR target/62128 in ChangeLog and > add 2 testases to gcc.target/i386 such that they fail > without this patch using the default GCC configuration.
Also, just use (avx2_rotate<mode>_perm): New. for the 4th ChangeLog entry line, no point duplicating sse.md... Jakub