On Thu, Sep 18, 2014 at 11:14 AM, Hans-Peter Nilsson <h...@bitrange.com> wrote:
> On Wed, 17 Sep 2014, Hans-Peter Nilsson wrote:
>> On Thu, 18 Sep 2014, Janne Blomqvist wrote:
>> > On Thu, Sep 18, 2014 at 12:57 AM, Hans-Peter Nilsson <h...@bitrange.com>
>> > wrote:
>> > > 'k so we'll track the regressions in a PR.
>> >
>> > Do you prefer to tack on to 62768 or a new PR?
>>
>> Hijacking 62768 for the purposes of reporting a regression for
>> its fix would not be proper.
>
>> Will tell in a new PR, unless I see a really obvious fix.
>
> False alarm.
Ok, good; I was a bit perplexed what could be wrong.
> If you look back at the patch I posted, there's a
> typo. :-} Duly warned about, but I'd rather expect the build to
> fail.
Yes, strange that it didn't fail. There's no prototype for cf_fstrcpy,
and since we use std=gnu11 prototypes should be mandatory. Also, since
there's no symbol called cf_fstrcpy so at least the linking should
fail. Unless the link picked up some old inquire.o file?
> Apparently libgfortran is not compiled with -Werror, at least
> not for crosses. Maybe -Werror is there for native but I'm not
> sure as I see some "warning: array subscript has type 'char'
> [-Wchar-subscripts]" which seems generic and also some others.
> Though no more than can be fixed or excepted, IMHO.
No, Werror isn't used. It was tried, but apparently caused issues.
>From the changelog:
2008-06-13 Tobias Burnus <bur...@net-b.de>
* configure.ac (AM_CFLAGS): Remove -Werror again.
* configure: Regenerate.
2008-06-13 Tobias Burnus <bur...@net-b.de>
PR libgfortran/36518
* configure.ac (AM_CFLAGS): Add -Werror.
* configure: Regenerate.
* m4/ifunction_logical.m4: Cast "n" to "(int)".
* generated/any_l16.c: Regenerate.
* generated/any_l2.c: Regenerate.
* generated/all_l1.c: Regenerate.
* generated/all_l2.c: Regenerate.
* generated/all_l16.c: Regenerate.
* generated/any_l4.c: Regenerate.
* generated/count_4_l.c: Regenerate.
* generated/count_8_l.c: Regenerate.
* generated/all_l4.c: Regenerate.
* generated/count_1_l.c: Regenerate.
* generated/count_16_l.c: Regenerate.
* generated/any_l8.c: Regenerate.
* generated/count_2_l.c: Regenerate.
* generated/any_l1.c: Regenerate.
* generated/all_l8.c: Regenerate.
I have a vague recollection that there were issues with system headers
on non-glibc targets. It would be nice if Werror was used by default,
I think we've had a few cases where bugs have slipped past due to it.
--
Janne Blomqvist
