On Fri, Sep 05, 2014 at 11:41:07AM +0200, Thomas Schwinge wrote:
> Shouldn't CILK_FOR also be added to gcc/gimplify.c:is_gimple_stmt, next
> to all the other OMP_FOR variants?
> 
> diff --git gcc/gimplify.c gcc/gimplify.c
> index 2319fc3..a621824 100644
> --- gcc/gimplify.c
> +++ gcc/gimplify.c
> @@ -4426,6 +4426,7 @@ is_gimple_stmt (tree t)
>      case OMP_FOR:
>      case OMP_SIMD:
>      case CILK_SIMD:
> +    case CILK_FOR:
>      case OMP_DISTRIBUTE:
>      case OACC_LOOP:
>      case OMP_SECTIONS:

Yes, and not just that, both CILK_SIMD and CILK_FOR are missing
e.g. in cp_gimplify_expr:
    case OMP_FOR:
    case OMP_SIMD:
    case OMP_DISTRIBUTE:
      ret = cp_gimplify_omp_for (expr_p, pre_p);
      break;
or in cp_genericize_r:
  else if (TREE_CODE (stmt) == OMP_FOR
           || TREE_CODE (stmt) == OMP_SIMD
           || TREE_CODE (stmt) == OMP_DISTRIBUTE)
    genericize_omp_for_stmt (stmt_p, walk_subtrees, data);

I'd suggest to grep for -w OMP_FOR and/or -w OMP_SIMD and
see if CILK_FOR or CILK_SIMD shouldn't be supported there too.

        Jakub

Reply via email to