On 4 September 2014 16:41, Wilco Dijkstra <wdijk...@arm.com> wrote: >> From: Marcus Shawcroft [mailto:marcus.shawcr...@gmail.com] >> > - NAMED_PARAM (FP2FP, 4) >> > + NAMED_PARAM (FP2FP, 2) >> >> This is not directly related to the change below and it is missing >> from the ChangeLog. Originally this number had to be > 2 in order >> for secondary reload to kick in. See the comment above the second >> hunk of this patch. Why is it OK to lower this number ? > > It is related because the GET_MODE_SIZE bug means it never returns the > correct cost, but instead returns the FP2FP cost. So the FP2FP cost had > to be artificially increased. With the fix this is no longer required.
Yep, I read the code again, I understand. You still need to fix the ChangeLog. OK to commit with a fixed ChangeLog. Cheers /Marcus
