On Fri, 15 Aug 2014, Sylvestre Ledru wrote: > It is indeed useless. I removed it. Thanks > http://sylvestre.ledru.info/0001-Enable-warning-Wreturn-type-by-default.patch
I don't think most of the testsuite changes in this patch should be needed, and we should be conservative about changing existing testcases because of the risk that it affects what they test. Most of the changes seem like they would only have been relevant for the previous version that enabled -Wmissing-return warnings by default. The change to gcc.dg/c90-impl-int-1.c is simply wrong - the specific point of that testcase is to test various cases of implicit int, so you can't add explicit int return types to it. You need, obviously, the new tests for how -W(no-)missing-return and -W(no-)return-type work and what the defaults are. Existing tests should only need to be changed if they do in fact fail with the compiler patch applied. -- Joseph S. Myers jos...@codesourcery.com
