On 05/22/14 07:16, Jakub Jelinek wrote:
On Thu, May 22, 2014 at 06:52:05AM -0600, Jeff Law wrote:
On 05/16/14 09:26, Tom Tromey wrote:

2014-05-16  Phil Muldoon  <pmuld...@redhat.com>
            Jan Kratochvil  <jan.kratoch...@redhat.com>
            Tom Tromey  <tro...@redhat.com>

        * gcc-c-fe.def: New file.
        * gcc-c-interface.h: New file.
        * gcc-interface.h: New file.
---

+GCC_METHOD7 (gcc_decl, build_decl,
+            const char */* name */,
+            enum gcc_c_symbol_kind /* sym_kind */,
+            gcc_type /* sym_type */,
+            const char */* substitution_name */,
+            gcc_address /* address */,
+            const char */* filename */,
+            unsigned int /* line_number */)

I must say that I hate the embedded comments in the signatures.
Especially when you end up with something like:

Why it can't be:
GCC_METHOD7 (gcc_decl, build_decl,
             const char *name,
             enum gfc_c_symbol_kind sym_kind,
...
i.e. provide comments in the form of argument names
(sure, you can't use bool for the name of the parameter then...).
No idea. I'd assumed they had it in a comment rather than in the signature for a reason.

jeff

Reply via email to