Hi! On Thu, 3 Apr 2014 18:13:08 +0200, Bernd Schmidt <ber...@codesourcery.com> wrote: > On 04/02/2014 10:36 AM, Thomas Schwinge wrote: > >> I see regressions in the libgomp testsuite for configurations where > >> offloading is not enabled: > >> > >> spawn [...]/build/gcc/xgcc -B[...]/build/gcc/ > >> [...]/source/libgomp/testsuite/libgomp.c/for-3.c > >> -B[...]/build/x86_64-unknown-linux-gnu/./libgomp/ > >> -B[...]/build/x86_64-unknown-linux-gnu/./libgomp/.libs > >> -I[...]/build/x86_64-unknown-linux-gnu/./libgomp > >> -I[...]/source/libgomp/testsuite/.. -fmessage-length=0 > >> -fno-diagnostics-show-caret -fdiagnostics-color=never -fopenmp -std=gnu99 > >> -fopenmp -L[...]/build/x86_64-unknown-linux-gnu/./libgomp/.libs -lm -o > >> ./for-3.exe > >> /tmp/ccGnT0ei.o: In function `main': > >> for-3.c:(.text+0x21032): undefined reference to `__OPENMP_TARGET__' > >> collect2: error: ld returned 1 exit status > >> > >> I suppose that's because [...] > > > > Workaround committed in r209015: > > > libgcc/ > > * crtstuff.c [!ENABLE_OFFLOADING] (__OPENMP_TARGET__): Define to > > NULL. > > The patch below should be a better fix, making the references to > __OPENMP_TARGET__ weak. Does this work for you?
Yes, it does, thanks! Please revert my patch when committing yours. Oh, and please use ChangeLog.gomp files on gomp-4_0-branch; also please move the entries for your recent commits from the ChangeLog file(s) to the respective ChangeLog.gomp one(s). Grüße, Thomas
pgp9LEYYQa4tJ.pgp
Description: PGP signature
