2014-04-03 21:28 GMT+04:00 Bernd Schmidt <ber...@codesourcery.com>: > On 04/03/2014 07:25 PM, Ilya Verbin wrote: >> >> Yes, initially the idea was to use it for look up the right function. >> But now each DSO will call GOMP_offload_register, and pass unique >> pointer to __OPENMP_TARGET__ (host_table) for this DSO. Then >> gomp_register_images_for_device registers all this host tables in the >> plugin. And when libgomp calls device_get_table_func, the plugin >> returns the joint table for all DSO's. > > > Why make a joint table? It seems better to use the __OPENMP_TARGET__ symbol > to restrict lookups to the subset of symbols that could actually be found. > BTW, I still expect that the lookup by ordering will turn out to be > fundamentally unreliable and we'll need to use the unique id patch I posted > a while ago. In that case using __OPENMP_TARGET__ as a first order key for > the lookups eliminates any problem with duplicate names across multiple > libraries. > > > Bernd >
In current implementation each gomp_device_descr contains one dev_splay_tree. And all addresses are inserted into this splay tree. There is no need to restrict lookup, because the addresses from multiple DSO's can't overlap. -- Ilya
