On Wed, Mar 5, 2014 at 10:20 AM, Jakub Jelinek <ja...@redhat.com> wrote:
>> > Pretty much all plugins fail to compile against installed plugin headers >> > on i?86, because stringop.def isn't installed. >> > >> > This patch should fix that, ok if testing succeeds? >> > >> > 2014-03-05 Jakub Jelinek <ja...@redhat.com> >> > >> > * config/i386/t-i386 (OPTIONS_H_EXTRA): Add stringop.def. >> >> This is actually PR59335 [1], and as shown there, a couple of other >> headers are missing as well. >> >> [1] http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59335 > > Ah, I see, not sure we have to handle everything at once though, it can be > fixed incrementally. > Anyway, as for OPTIONS_H_EXTRA vs. PLUGIN_HEADERS, I think the former is > more correct, stringop.def is included by i386-opts.h. > And x86-tune.def, being included directly by i386.h, should be added to > TM_H. > So is this ok instead? > > Note, only tested with make install and checking that the *.def file is > installed. > > 2014-03-05 Jakub Jelinek <ja...@redhat.com> > > PR plugins/59335 > * config/i386/t-i386 (OPTIONS_H_EXTRA): Add stringop.def. OK with updated ChangeLog. Thanks, Uros.
