On Wed, Mar 05, 2014 at 10:10:13AM +0100, Uros Bizjak wrote:
> On Wed, Mar 5, 2014 at 9:48 AM, Jakub Jelinek <ja...@redhat.com> wrote:
> > Hi!
> >
> > Pretty much all plugins fail to compile against installed plugin headers
> > on i?86, because stringop.def isn't installed.
> >
> > This patch should fix that, ok if testing succeeds?
> >
> > 2014-03-05 Jakub Jelinek <ja...@redhat.com>
> >
> > * config/i386/t-i386 (OPTIONS_H_EXTRA): Add stringop.def.
>
> This is actually PR59335 [1], and as shown there, a couple of other
> headers are missing as well.
>
> [1] http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59335
Ah, I see, not sure we have to handle everything at once though, it can be
fixed incrementally.
Anyway, as for OPTIONS_H_EXTRA vs. PLUGIN_HEADERS, I think the former is
more correct, stringop.def is included by i386-opts.h.
And x86-tune.def, being included directly by i386.h, should be added to
TM_H.
So is this ok instead?
Note, only tested with make install and checking that the *.def file is
installed.
2014-03-05 Jakub Jelinek <ja...@redhat.com>
PR plugins/59335
* config/i386/t-i386 (OPTIONS_H_EXTRA): Add stringop.def.
--- gcc/config/i386/t-i386.jj 2014-01-03 11:41:06.000000000 +0100
+++ gcc/config/i386/t-i386 2014-03-05 09:40:22.433466727 +0100
@@ -16,11 +16,13 @@
# along with GCC; see the file COPYING3. If not see
# <http://www.gnu.org/licenses/>.
+OPTIONS_H_EXTRA += $(srcdir)/config/i386/stringop.def
+TM_H += $(srcdir)/config/i386/x86-tune.def
+
i386-c.o: $(srcdir)/config/i386/i386-c.c i386-builtin-types.inc
$(COMPILE) $<
$(POSTCOMPILE)
-
i386-builtin-types.inc: s-i386-bt ; @true
s-i386-bt: $(srcdir)/config/i386/i386-builtin-types.awk \
$(srcdir)/config/i386/i386-builtin-types.def
Jakub
