Hi,
On Thu, 19 Dec 2013 11:55:03, Eric Botcazou wrote: > >> In general I like the comment, and I am open for other suggestions how >> to call the parameter. > > I think that using EXPAND in the parameter's name is confusing because it > needs to be distinguished from MODIFIER and its enumeration type. And since > it would be true only after calling get_inner_reference, it would be better to > have the "inner" as well. Maybe inner_reference_p or something equivalent. > Ok, thanks, you are right. I like this name too, and I think it will be generally acceptable. Attached is a new version of my patch with s/expand_reference/inner_reference_p/ and your comment added. Richard, I personally, would prefer this patch over proposal #1, because it is a smaller change in the end. OK for trunk? Bernd.
2013-12-19 Bernd Edlinger <bernd.edlin...@hotmail.de>
PR middle-end/57748
* expr.h (expand_expr_real, expand_expr_real_1): Add new parameter
inner_reference_p.
(expand_expr, expand_normal): Adjust.
* expr.c (expand_expr_real, expand_expr_real_1): Add new parameter
inner_reference_p. Use inner_reference_p to expand inner references.
(store_expr): Adjust.
* cfgexpand.c (expand_call_stmt): Adjust.
testsuite:
2013-12-19 Bernd Edlinger <bernd.edlin...@hotmail.de>
PR middle-end/57748
* gcc.dg/torture/pr57748-3.c: New test.
* gcc.dg/torture/pr57748-4.c: New test.
patch-pr57748-2.diff
Description: Binary data
