On Tue, Nov 12, 2013 at 11:34:48AM -0800, Kostya Serebryany wrote:
> On Tue, Nov 12, 2013 at 11:30 AM, Jakub Jelinek <ja...@redhat.com> wrote:
> > On Tue, Nov 12, 2013 at 10:59:12AM -0800, Kostya Serebryany wrote:
> >> This is all dead code in gcc repo. This is why I am asking for any
> >> quick #ifdef.
> >> in clang repo this code is used by MemorySanitizer (and will be used
> >> by asan/tsan later).
> >
> > I can't find how it is used in msan/ in the llvm repo either, though
> > admittedly just using grep (was grepping for pre_impl or post_impl),
> > but sanitizer_common_syscalls.inc #undefs PRE_SYSCALL/POST_SYSCALL
> 
> we only have it in tests: msan/lit_tests/Linux/syscalls.cc
> 
> > at the end, so I'm curious how do you use it.  But not enough interest
> > to actually build the llvm stuff.
> >
> > Anyway, the following #ifdefs out tons of dead code and still builds just
> 
> Thanks, that should work.
> I am really sorry I couldn't do it myself before -- just got back from travel.

In the future, don't commit patches like this just before travel, unless you
know you will have a good internet connection where you are going, and you will
have enough cycles to spare from your travels to fix any fall out.

-- 
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460, USA
email: meiss...@linux.vnet.ibm.com, phone: +1 (978) 899-4797

Reply via email to