On Tue, Nov 12, 2013 at 11:34:48AM -0800, Kostya Serebryany wrote:
> > Anyway, the following #ifdefs out tons of dead code and still builds just
> 
> Thanks, that should work.
> I am really sorry I couldn't do it myself before -- just got back from travel.

So do you have some suggestion for #ifdef KERNEL_HEADER_WORKAROUND so it
won't confuse you during next merge?

> > fine, the only difference is that those symbols nothing really uses from
> > libasan/libtsan are no longer exported, but nothing else changes.
> >
> > I guess the #if 0 can be replaced by some #ifdef with some nice name or
> > something.
> >
> > BTW, the 10MB .bss in libubsan is really insane, while perhaps users are
> > expecting to have huge overhead with libasan or libtsan, for libubsan it
> > looks way too big.  Why do you need it?
> 
> libubsan is a bit too far away from me, and especially the gcc build of it.

It is sanitizer_allocator.cc's
static ALIGNED(64) char internal_alloc_placeholder[sizeof(InternalAllocator)];
Dunno why it is so huge, why libubsan needs an allocator at all, etc.

        Jakub

Reply via email to