On Mon, 14 Oct 2013, Dodji Seketeli wrote: > > This patch has passes the existing -Wconversion testcases. It modifies > > Wconversion-real.c, Wconversion-real-integer.c and pr35635.c to be more > > specific > > If the patch passes existing tests, I'd be inclined to leave them > tests alone and add new ones that are specific to what this patch
Indeed, it's best not to change what an existing test tests. > > * gcc/c-family/c-common.c Switching unsafe_conversion_p to > > return an enumeration with more detail, and conversion_warning > > to use this information. > > The correct format for this ChangeLog entry would be: > > <tab>* gcc/c-family/c-common.c (unsafe_conversion_p): > <insert-your-comment-here>. And ChangeLog entries give the path to the file relative to the relevant ChangeLog file, which is that in the closest containing directory to the file being modified. Since there's one in gcc/c-family, that means the path in this case is just c-common.c. -- Joseph S. Myers jos...@codesourcery.com
