Donald R Robertson III or the current copyright clerk, Can you check and make sure that my copyright assignment paperwork is finished? I was number: 746725 It should have been received September 20, 2013.
Thank you. Joshua Cogliati -------------------------------------------- On Tue, 11/5/13, Dodji Seketeli <do...@redhat.com> wrote: Subject: Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion To: "Joshua J Cogliati" <jrinc...@yahoo.com> Cc: "Joseph S. Myers" <jos...@codesourcery.com>, gcc-patches@gcc.gnu.org, ja...@redhat.com, m...@gcc.gnu.org Date: Tuesday, November 5, 2013, 5:12 AM Sorry for my late reply on this. I just have one very small nit for one ChangeLog entry, expressed below. If nobody objects in the next 48 hours, I'd say this is OK to commit with the nit fixed. I am not seeing your name in the MAINTAINERS file. Have you filed copyright assignment to the FSF and do you have it all sorted? Joshua J Cogliati <jrinc...@yahoo.com> writes: > Since part of it was to go into c-family (as per Joseph S. Myers's > email) and parts are not in c-family, I split the changelog into three > parts. I also changed the formatting of the changelog and patch as > per Dodji's comments. The attached patch is the same as before, but > the diff for Wfloat-conversion.c is as a new file, not as a copy of > Wconversion-real.c. Thanks for reviewing it. If there is anything > else that needs changing, please tell me. > > > For gcc/c-family/ChangeLog: > > PR c/53001 > Splitting out a -Wfloat-conversion from -Wconversion for > conversions that lower floating point number precision > or conversion from floating point numbers to integers > * c-common.c (unsafe_conversion_p): Make this function > return an enumeration with more detail. This is nicely formatted now, thank you. > (conversion_warning): Use the new return type of > unsafe_conversion_p to separately warn either about conversions > that lower floating point number precision or about the other > kinds of conversions. > * c-common.h: Adding conversion_safety enumeration. > (unsafe_conversion_p): switching return type to > conversion_safety enumeration. Here, this should be: * c-common.h (enum conversion_safety): New enumeration. (unsafe_conversion_p): switching return type to conversion_safety enumeration. OK to commit with the above changes, if you have your copyright properly assigned to the FSF. Thank for working on this. It is appreciated. -- Dodji
