> Yeah, good point. TBH I prefer it with separate ifs though, because the > three cases are dealing with three different types of rtl (unary, binary > and ternary). But I don't mind much either way.
Ok, it's fine for me too. > The new patch looks good to me, thanks. Just one minor style nit: > "return false" rather than "return 0" for the bool. Maybe also change: > > /* Bitfield operations [SIGN|ZERO]_EXTRACT from the least significant > bit can be used too. */ > > to something like: > > /* A [SIGN|ZERO]_EXTRACT from the least significant bit effectively > acts as a combined truncation and extension. */ Yeah, its clearer. I'll post the new patch in the other thread. > I really will try to make that my last comment and leave things open > for an official review :-) :-) once again many thanks for your help Richard. Cheers, Yvan
