Hi, Jakub! Thanks a lot for you remarks!
Attached is the patch which fixes all of them.
Ok to install if all testing passes?
Changelog:
gcc/
2013-06-03 Yuri Rumyantsev <yuri.s.rumyant...@intel.com>
* config/i386/i386.c (ix86_lea_outperforms): Fix formatting.
(ix86_avoid_lea_for_addr): Likewise.
(exact_dependency_1): Likewise.
(ix86_adjust_cost): Likewise.
(swap_top_of_ready_list): Fix formatting and !reload_completed check
removed.
(do_reorder_for_imul): Fix typo, formatting and
!reload_completed check removed.
(ix86_sched_reorder): Fix typo and formatting.
(fold_builtin_cpu): Move M_INTEL_SLM at the end of processor types
list.
libgcc/
2013-06-03 Yuri Rumyantsev <yuri.s.rumyant...@intel.com>
* config/i386/cpuinfo.c (INTEL_SLM): New enum value.
--------------------
2013/6/1 Jakub Jelinek <ja...@redhat.com>:
> On Sat, Jun 01, 2013 at 03:52:55PM +0200, Jakub Jelinek wrote:
>> On Fri, May 31, 2013 at 04:56:35PM +0400, Igor Zamyatin wrote:
>> > Like this?
>>
>> Sorry for nitpicking, but there are various formatting issues.
>
> Also:
> if (clock1 == clock2)
> {
> /* Determine winner - load must win. */
> enum attr_memory memory1, memory2;
> memory1 = get_attr_memory (top);
> memory2 = get_attr_memory (next);
> if (memory2 == MEMORY_LOAD && memory1 != MEMORY_LOAD)
> return true;
> }
> should indent { by 2 columns (i.e. use tab) from if, the body
> shouldbe moved 2 extra columns to the right and } as well.
>
> And there is i>= 0 in the patch (missing space after i).
>
> No idea why you do if (!reload_completed) return something;
> in swap_top_of_ready_list and do_reoder_for_imul, when those
> functions are only ever called from ix86_sched_reorder which bails
> out early if !reload_completed.
>
> Jakub
gcc_slm_patch3_2_review.patch
Description: Binary data
