On Fri, May 24, 2013 at 05:52:11PM +0000, Iyer, Balaji V wrote:
>       * gcc.dg/cilk-plus/AN/array_test1.c: New test.
...
>       * gcc.dg/cilk-plus/AN/cilkplus_AN_c.exp: New script.
Ok, I guess I can live with /AN/ extra level, but can you please
move it still to c-c++-common/cilk-plus/AN/ for all tests that can
be shared with C++?  Look at c-c++-common/ current tests, see
how they can use { target c } or { target c++ } etc. if there is say
small difference in diagnostics, but still most of the test is the same.

I don't like the cilkplus_AN_c.exp, IMNSHO you should just have
gcc.dg/cilk-plus/cilk-plus.exp that handles everything.  For how
is it supposed to load the files from subdirectories or how is it supposed
to load c-c++-common/cilk-plus/ testcases please look at g++.dg/dg.exp
and/or gcc.dg/dg.exp.

        Jakub

Reply via email to