r194120. I've tested it on Linux, but not on Mac.
On Tue, Dec 4, 2012 at 6:44 AM, Alexander Potapenko <gli...@google.com> wrote: > I've added MISSING_BLOCKS_SUPPORT to LLVM compiler-rt in r169206. > The rest of your change looks good to me as well. > > On Mon, Dec 3, 2012 at 6:33 PM, Alexander Potapenko <gli...@google.com> wrote: >> Jack, >> >> Note that MAC_INTERPOSE_FUNCTIONS is always defined in interception.h >> to either 0 or 1. >> I'm going to keep "#if MAC_INTERPOSE_FUNCTIONS" (adding "&& >> !defined(MISSING_BLOCKS_SUPPORT) >> " where appropriate) in libsanitizer. >> >> On Mon, Dec 3, 2012 at 11:17 AM, Mike Stump <mikest...@comcast.net> wrote: >>> On Dec 3, 2012, at 8:02 AM, Jack Howarth <howa...@bromo.med.uc.edu> wrote: >>>> The attached patch eliminates PR 55521/sanitizer by switching libasan on >>>> darwin >>>> from using mach_override to mac function interposition >>> >>> So, I'm thinking the sanitizer people will just review and approve it, even >>> though it says darwin and is heavily darwin specific… It's ok by me. >> >> >> >> -- >> Alexander Potapenko >> Software Engineer >> Google Moscow > > > > -- > Alexander Potapenko > Software Engineer > Google Moscow
