On Mon, Dec 3, 2012 at 3:52 AM, Jakub Jelinek <ja...@redhat.com> wrote: > Hi! > > On Thu, Nov 29, 2012 at 12:20:39PM -0800, H.J. Lu wrote: >> On Thu, Nov 29, 2012 at 11:06 AM, Jakub Jelinek <ja...@redhat.com> wrote: >> > On Thu, Nov 29, 2012 at 07:24:38PM +0100, Paolo Carlini wrote: >> >> On 11/29/2012 06:36 PM, Tobias Burnus wrote: >> >> >H.J. Lu wrote: >> >> >>This patch adds --with-build-config=bootstrap-asan support. Tested on >> >> >>Linux/x86-64. OK to install? >> >> > >> >> >I think that patch has broken bootstrap for me. If I do a normal >> >> >bootstrap, Stage1 fails with: >> >> > >> >> >libtool: compile: unrecognized option `-D_GNU_SOURCE' >> >> >libtool: compile: Try `libtool --help' for more information. >> >> >make[4]: *** [interception_linux.lo] Error 1 >> >> >make[4]: Leaving directory >> >> >`/home/burnus/gcc/build/x86_64-unknown-linux-gnu/libsanitizer/interception' >> >> Likewise here. Would it be possible to revert the offending commit, >> >> in the meanwhile? >> > >> > Yes, H.J., please revert the patch, I thought you have tested it alone >> > without any further patches. For the -I patch, I really would prefer if >> > libsanitizer just had a dependency on libstdc++ at toplevel >> > (configure-target-sanitizer depending on all-target-libstdc++-v3), >> > then you can (and similarly for host variants if we need host sanitizer at >> > all). Then you should be able to use scripts/testsuite_flags >> > --build-includes just fine. >> >> I opened: >> >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55533 >> >> to explain why scripts/testsuite_flags doesn't work when >> bootstrapping libsanitizer. > > CCing Paolo and Alex as build maintainers on this, using the script > is just my preference and not sure whether it is feasible or not, though > IMHO if there is a dependency on libstdc++-v3 being built before > libsanitizer is configured (or perhaps just configure when it has been > configured and build when it has been built), I don't see why it couldn't > be used in theory. I'll defer this to them. >
Hi Alex, Paolo, This is related to http://gcc.gnu.org/ml/gcc-patches/2010-11/msg01430.html http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46026 The problem is CXX_FOR_TARGET used to configure libsanitizer was expanded before libstdc++-v3 is configured when we are bootstrapping libsanitizer. I opened: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55533 with a fix at http://gcc.gnu.org/ml/gcc-patches/2012-11/msg02480.html Can you take a look at it? Thanks. -- H.J.
