On Thu, Nov 29, 2012 at 11:03 AM, H.J. Lu <hjl.to...@gmail.com> wrote: > On Thu, Nov 29, 2012 at 10:32 AM, H.J. Lu <hjl.to...@gmail.com> wrote: >> On Thu, Nov 29, 2012 at 10:24 AM, Paolo Carlini >> <paolo.carl...@oracle.com> wrote: >>> On 11/29/2012 06:36 PM, Tobias Burnus wrote: >>>> >>>> H.J. Lu wrote: >>>>> >>>>> This patch adds --with-build-config=bootstrap-asan support. Tested on >>>>> Linux/x86-64. OK to install? >>>> >>>> >>>> I think that patch has broken bootstrap for me. If I do a normal >>>> bootstrap, Stage1 fails with: >>>> >>>> libtool: compile: unrecognized option `-D_GNU_SOURCE' >>>> libtool: compile: Try `libtool --help' for more information. >>>> make[4]: *** [interception_linux.lo] Error 1 >>>> make[4]: Leaving directory >>>> `/home/burnus/gcc/build/x86_64-unknown-linux-gnu/libsanitizer/interception' >>> >>> Likewise here. Would it be possible to revert the offending commit, in the >>> meanwhile? >>> >> >> This is a known problem. Please try: >> >> http://gcc.gnu.org/ml/gcc-patches/2012-11/msg02480.html >> >> I updated my patch for the newly added tsan. It fixed >> bootstrap on Linux/ia32. >> > > I checked in my patch to restore bootstrap after tested > on Linux/ia32 and Linux/x86-64. I will revert both patches > if my fix is incorrect.
This is not how patch review is supposed to work. Thanks, Andrew
