On Tue, Nov 20, 2012 at 9:26 AM, David Miller <da...@davemloft.net> wrote: > From: Konstantin Serebryany <konstantin.s.serebry...@gmail.com> > Date: Tue, 20 Nov 2012 09:20:29 +0400 > >> Please do (the same that was applied upstream). > > Which one was that? http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cc?r1=168301&r2=168300&pathrev=168301
> >> Please also note: >> - I am on vacation with random access to PC, that's why I did not >> want to rush with my first commits to gcc trunk. > > This is actually another argument for not having external dependencies > on fixing ASAN problems directly in the GCC sources. Agree (bad timing, another maintainer from our side is on a conference). > >> - asan for SPARC is not known to work at all (is it?) and thus a >> simpler fix might be to disable it for now. > > I asked for the code to be enabled, because this code should be > portable to all Linux systems and I also plan to work on Sparc support > as the backend bits doesn't look terribly difficult (and this is > largely proven by how fast the powerpc port was written). Cool! (the port should be easy indeed given that we have ARM, PowerPC and x86) > > But this fix also cures problems on supported targets.