On Thu, 25 Oct 2012, Jakub Jelinek wrote:

> On Thu, Oct 25, 2012 at 12:58:26PM +0200, Richard Biener wrote:
> > So the bug here is really in find_many_sub_basic_blocks then
> > and your patch would certainly avoid triggering its bug
> > (or its wrong expectations).  I'll give it testing.
> 
> I'd say we should insert the __builtin_unreachable already far earlier than
> that, either when inlining the noreturn function and figuring out
> it might return (perhaps conditionally on something that never happens),
> or if LTO does something similar with it even without inlining.

That would be fixup_cfg which is supposed to deal with this kind of
"fallout", like in my original patch (just using __builtin_unreachable ()
instead of an infinite loop edge)
  
Honza?

Richard.

Reply via email to