> From: Kumar, Venkataramanan <[email protected]> > Sent: Friday, August 28, 2026 1:00 PM > > > From: Jiang, Haochen <[email protected]> > > Sent: Friday, August 28, 2026 8:51 AM > > > > > From: Kumar, Venkataramanan <[email protected]> > > > Sent: Friday, August 28, 2026 1:03 AM > > > > > > > From: Haochen Jiang <[email protected]> > > > > Sent: Wednesday, August 19, 2026 11:19 AM > > > > > > What about adding runtime tests for cvtrow* patterns? > > > They should get tested under targets having ACEV1 and no AMX-AVX512. > > > > I suppose runtime test are not needed since they are redundant with the > > same behavior. > > > > We already have compile test to make sure it is correctly generated. > > > > OK. > > > > > > > > > gcc/ChangeLog: > > > > > > > > * config/i386/acev1intrin.h: Add new intrins. > > > > * config/i386/i386-builtin-types.def: Add new builtin types. > > > > * config/i386/i386-builtin.def (BDESC): Handle new builtins. > > > > * config/i386/i386-expand.cc > > > > (ix86_expand_ace_builtin): Handle new builtin type. > > > > * config/i386/sse.md (UNSPEC_TCVTROWD2PS) New. > > > > (UNSPEC_TCVTROWPS2FP16H): Ditto. > > > > (UNSPEC_TCVTROWPS2FP16L): Ditto. > > > > (UNSPEC_TILEMOVROWEXTRACT): Ditto. > > > > (UNSPECV_TILEMOVROWINSERT): Ditto. > > > > (UNSPECV_TILEMOVCOLINSERT): Ditto. > > > > (VHFBF_512): Ditto. > > > > (tcvtrowd2ps): Ditto. > > > > (tcvtrowps2<bf16_ph><highlowsuffix>): Ditto. > > > > (tilemovrow_extract): Ditto.: > > > Remove : > > > > (tilemov<rowcol>_insert): Ditto. > > > > This is actually added in patterns? > This is a minor nit I saw extra : >
Oh I get your point then. I will remove that. Thx, Haochen
