Hello! >> +2012-10-09 Venkataramanan Kumar <venkataramanan.ku...@amd.com> >> + >> + PR testsuite/53397 >> + * gcc/testsuite/gcc.dg: Remove test cases pr53397-1.c and pr53397-2.c >> + they are moved to gcc.target/i386 as they are specific to i386/x86_64. >> + * gcc/testsuite/gcc.target/i386/pr53397-1.c: New test >> + Checks we are prefetching for loop invariant steps >> + * gcc/testsuite/gcc.target/i386/pr53397-2.c: New test >> + Checks we are not prefetching for loop variant steps > > The ChangeLog entry is wrong. No gcc/testsuite/ paths, sentences should > end with dot, no need to explain why you are doing the change. > Just write: > PR testsuite/53397 > * gcc.dg/pr53397-1.c: Moved to... > * gcc.target/i386/pr53397-1.c: ... here. Add -msse2 to dg-options. > * gcc.dg/pr53397-2.c: Moved to... > * gcc.target/i386/pr53397-2.c: ... here. Add -msse2 to dg-options. > > Ok with that change (though, preferrably just do svn mv of the files, then > add -msse2, edit ChangeLog and commit).
Please also note that the entry should go into testsuite/ChangeLog. Also, +/* { dg-do compile { target { i?86-*-* x86_64-*-* } } } */ target does not need to be specified, we are in config/i386 directory already. Uros.