On Sat, Oct 6, 2012 at 4:10 PM, Jan Hubicka <hubi...@ucw.cz> wrote: >> > Index: passes.c >> > +/* Hold statistic about profile consistency. */ >> ... >> >> I don't see why this should live in passes.c, can you please put it in >> a more logical place (profile.c, perhaps)? > > Hmm, the problem here is that the code is using passmanager's dumping bits > to order the passes and assign them names. So moving it elsewhere requires > exporting it that is not nice. passes.c does similar stuff already, so I > decided > to keep it there.
I think this is not the right decision. We can also throw _all_ code on one pile because there are inter-dependencies. Or they can be fixed with a proper interface. > If there are no complains I will commit the patch tomorrow. +1 complaint. You're putting profile stuff and even RTL stuff in the pass manager. That is Just Wrong. Ciao! Steven
