Hi Robin,

I just sent v2.

> Is VWEXTI = VWEXTI_HS + VWEXTI_D?  I guess it should :)  Can we combine 
> it?
> 

I rewrote the new VWEXTI iterator using VWEXTI_HS and VWEXTI_D in v2.

> > +(define_mode_iterator V_VLSI_SD [V_VLSI_S V_VLSI_D])
> > +
> 
> Leftover?
> 

Removed.

> > diff --git a/gcc/testsuite/gcc.target/riscv/rvv/autovec/zvabd-2.c 
> > b/gcc/testsuite/gcc.target/riscv/rvv/autovec/zvabd-2.c
> > new file mode 100644
> > index 00000000000..a3e624d8362
> > --- /dev/null
> > +++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/zvabd-2.c
> > +
> > +/* { dg-final { scan-assembler-not {vabd\.vv} } } */
> > +/* { dg-final { scan-assembler-not {vwabda\.vv} } } */
> 
> Can you fold these into zvabd-1.c?  Add the unsupported types to 
> TEST_ALL and keep the assembler tests the same.
> 

Done.

> Of course execution tests would be nice as well.  I'd say not in scope 
> for this fix but generally desirable.  That would be a somewhat
> larger change due to the necessary testsuite/dejagnu boilerplate.

Maybe I could send a separate patch on this later?

> 
> The rest looks good to me.
> 
> -- 
> Regards
>  Robin

Thanks,
Bohan

Reply via email to