On 8/15/12, Richard Guenther <rguent...@suse.de> wrote: > On Wed, 15 Aug 2012, Michael Matz wrote: > > On Wed, 15 Aug 2012, Richard Guenther wrote: > > > Like the following, only the coverage.c use is converted. > > > I've never seen template function arguments anywhere and > > > having to repeat them all > > > > > > over the place is really really ugly (yes, even if only in > > > the implementation). > > > > > > This goes with static member functions and not wrapping any > > > data. It goes away with the requirement of having externally > > > visible global functions for the hash/compare functions as well > > > (which was ugly anyway). > > > > Well, it looks nicer than what's there currently. As the > > element functions now are scoped and normal member functions, > > they should be named with lower case characters of course. I do > > like that the hash table would then only have one real template > > argument; the Allocator, well, no better idea comes to my mind. > > Yeah. Updated patch below, all users converted. I probably > missed to revert some of the globalizations of hash/compare fns.
Your conversion is a better abstraction, and something I'd wanted to get to eventually, so I support your conversion. BTW, the conding conventions say to put member function definitions out of line. -- Lawrence Crowl
