On 5/27/25 12:27 AM, Robin Dapp wrote:
Apart from that it LGTM, thanks for digging deeper here.
Just wanted to echo this. I've had a low priority todo to review vaaddu
and friends after seeing them get used in some hand coded versions of
various routines in x264. Even if you're not tackling that specific
problem the effort in this space is definitely appreciated.
The VXRM mode switching may make this not-so-profitable, though I hope
those problems are limited to early designs and that it'll be handled in
a more performant way in the future. Point being we need to keep an eye
out for regressions and if seen we'll need to make this behavior
conditional on a flag in the tuning structure.
Jeff
