Hi Robin: Pushed to trunk, thanks,
On Mon, Mar 31, 2025 at 11:23 PM Robin Dapp <rdapp....@gmail.com> wrote: > > LGTM (even though I still don't like the spec :D). Yeah...and I also don't like the magic "ceil(AVL / 2) ≤ vl ≤ VLMAX if AVL < (2 * VLMAX)" rule... > We still have an implicit assumption in riscv-vsetvl.cc that might modify > LMUL: Thanks for reminding me, will take a look to see if that will cause problems :) > > In prev_ratio_valid_for_next_sew_p and next_ratio_valid_for_prev_sew_p we > check > whether the ratio of two LMULs is <= 8. ISTR that with recent changes we only > re-use an existing ratio and don't compute a new one but it might be worth a > second look. A while ago we certainly did change LMUL even to values that > weren't initially enabled. > > -- > Regards > Robin >
