Robert Dubner <rdub...@symas.com> writes: >> -----Original Message----- >> From: Jakub Jelinek <ja...@redhat.com> >> Sent: Tuesday, March 11, 2025 17:40 >> To: Robert Dubner <rdub...@symas.com> >> Cc: gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH] Add Robert Dubner to Maintainers >> >> On Tue, Mar 11, 2025 at 02:24:26PM -0500, Robert Dubner wrote: >> > As described in https://gcc.gnu.org/gitwrite.html, this is my >> > inaugural, no-prior-approval-required, is-it-working? >> > --yes-it-is-I-just-did-it patch to MAINTAINERS >> > >> > diff --git a/MAINTAINERS b/MAINTAINERS index 84c0a6b892b..34e2f9f53b7 >> > 100644 >> > --- a/MAINTAINERS >> > +++ b/MAINTAINERS >> > @@ -162,6 +162,7 @@ Ada front end Arnaud Charlet >> > <char...@adacore.com> >> > Ada front end Eric Botcazou >> > <ebotca...@libertysurf.fr> >> > Ada front end Marc Poulhiès > <poulh...@adacore.com> >> > Ada front end Pierre-Marie de Rodat <dero...@adacore.com> >> > +COBOL front end Robert Dubner <rdub...@symas.com> >> > c++ Jason Merrill <ja...@redhat.com> >> > c++ Nathan Sidwell <nat...@acm.org> >> > D front end Iain Buclaw >> <ibuc...@gdcproject.org> >> >> You can't be a maintainer (the first hunk) and reviewer (second hunk) at >> the same time. The difference between maintainer and reviewer is that >> maintainer can commit his own patches to the maintained subsystem > without >> review (doesn't mean he can't ask for review). >> So, if the steering committee appointed you as maintainer, you should be >> just in the first hunk, if as a reviewer, second hunk. >> The third hunk is ok if you want all your commits go under DCO. > > My batting average remains at a thousand -- I never get things right on > the first try. > > I don't know how the Steering Committee has designated me. I will say > that it had best be as Front End Maintainer, because if Jim and I don't do > it, the project is going to be, I suspect, very hard pressed to find > somebody else to do it.
Think the question is more if they appointed you both as maintainers or what (I'm sure they have, though). > > This does beg another question: If somebody wants to submit a patch that > affects the code in the COBOL front end, and if I am not in the role of > reviewing those changes, well, who is supposed to do the review? Or is > that understood to fall under the aegis of Front End Maintainer? > Maintainers have the powers of reviewers and then some (like appointing new reviewers, or at least recommending them). > The FSF has a copyright assignment for me on file. > > In any event, I will edit myself out of everything except Front End > Maintainer. > That sounds good and correct if you've got an FSF copyright assignment on file (hence not using DCO). > Thank you, > > Bob D. > >> [...] sam
