On Tue, Mar 11, 2025 at 02:24:26PM -0500, Robert Dubner wrote: > As described in https://gcc.gnu.org/gitwrite.html, this is my inaugural, > no-prior-approval-required, is-it-working? --yes-it-is-I-just-did-it patch > to MAINTAINERS > > diff --git a/MAINTAINERS b/MAINTAINERS > index 84c0a6b892b..34e2f9f53b7 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -162,6 +162,7 @@ Ada front end Arnaud Charlet > <char...@adacore.com> > Ada front end Eric Botcazou > <ebotca...@libertysurf.fr> > Ada front end Marc Poulhiès <poulh...@adacore.com> > Ada front end Pierre-Marie de Rodat <dero...@adacore.com> > +COBOL front end Robert Dubner <rdub...@symas.com> > c++ Jason Merrill <ja...@redhat.com> > c++ Nathan Sidwell <nat...@acm.org> > D front end Iain Buclaw <ibuc...@gdcproject.org>
You can't be a maintainer (the first hunk) and reviewer (second hunk) at the same time. The difference between maintainer and reviewer is that maintainer can commit his own patches to the maintained subsystem without review (doesn't mean he can't ask for review). So, if the steering committee appointed you as maintainer, you should be just in the first hunk, if as a reviewer, second hunk. The third hunk is ok if you want all your commits go under DCO. > @@ -276,6 +277,7 @@ check in changes outside of the parts of the compiler > they maintain. > arm port (MVE) Christophe Lyon <christophe.l...@arm.com> > callgraph Martin Jambor <mjam...@suse.cz> > C front end Marek Polacek <pola...@redhat.com> > +COBOL front end Robert Dubner <rdub...@symas.com> > CTF, BTF Indu Bhagat <indu.bha...@oracle.com> > CTF, BTF, bpf port David Faust <david.fa...@oracle.com> > dataflow Paolo Bonzini <bonz...@gnu.org> > @@ -445,6 +447,7 @@ Dimitar Dimitrov dimitar > <dimi...@dinux.eu> > Benoit Dupont de Dinechin bd3 > <benoit.dupont-de-dinec...@st.com> > Lehua Ding - <lehua.d...@rivai.ai> > Ulrich Drepper drepper <drep...@gmail.com> > +Robert Dubner rdubner <rdub...@symas.com> > François Dumont fdumont <fdum...@gcc.gnu.org> > Zdenek Dvorak rakdver <o...@ucw.cz> > Michael Eager eager <ea...@eagercon.com> Jakub