Hi,
On Sat, 2025-01-18 at 09:34 +0800, Monk Chiang wrote:
> Thanks, I will fix it.
Thanks. And if you need help with that please let people know.
The riscv bootstrap has been broken now for 5 days.
And it really looks like it is as simple as just removing that one
line.
Cheers,
Mark
>
> > Mark Wielaard <m...@klomp.org> 於 2025年1月17日 晚上10:32 寫道：
> >
> > Hi Monk,
> >
> > > On Fri, Nov 15, 2024 at 06:53:09PM +0800, Monk Chiang wrote:
> > > gcc/ChangeLog:
> > > * gcc/config/riscv/riscv.cc
> > > (riscv_file_end_indicate_exec_stack): Add .note.gnu.property.
> > > * gcc/config/riscv/linux.h (TARGET_ASM_FILE_END): Define.
> > >
> > > [...]
> > > diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
> > > index 8201a965ed1..bda982f085c 100644
> > > --- a/gcc/config/riscv/riscv.cc
> > > +++ b/gcc/config/riscv/riscv.cc
> > > @@ -10195,6 +10195,56 @@ riscv_file_start (void)
> > > riscv_emit_attribute ();
> > > }
> > >
> > > +void
> > > +riscv_file_end_indicate_exec_stack ()
> > > +{
> > > + file_end_indicate_exec_stack ();
> > > + long GNU_PROPERTY_RISCV_FEATURE_1_AND = 0;
> >
> > This broke the riscv bootstrap because
> > GNU_PROPERTY_RISCV_FEATURE_1_AND is never used.
> >
> > ../../gcc/gcc/config/riscv/riscv.cc:10340:8: error: unused variable
> > ‘GNU_PROPERTY_RISCV_FEATURE_1_AND’ [-Werror=unused-variable]
> > 10340 | long GNU_PROPERTY_RISCV_FEATURE_1_AND = 0;
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > See https://builder.sourceware.org/buildbot/#/builders/310/builds/863
> >
> > Could you fix that?
> >
> > Thanks,
> >
> > Mark
