On Mon, Jan 06, 2025 at 07:52:23AM -0700, Jeff Law wrote: > > > On 1/4/25 11:01 AM, Dimitar Dimitrov wrote: > > Add new effective target check for either ILP32E or ILP64E ABI variants. > > > > Initial implementation only checks for RV32E or RV64E ISA, which in turn > > implies that ILP32E/ILP64E ABI is used. The RV32I+ILP32E and > > RV64I+ILP64E combinations are not yet caught by the check, but they > > do not seem to be widely used currently. > > > > gcc/testsuite/ChangeLog: > > > > * lib/target-supports.exp (check_effective_target_riscv_abi_e): > > New procedure. > All 4 patches in this series are fine. I do fear that trying to keep the E > variants "clean" will be a long term maintenance task though. Hell, we're > struggling with keeping the existing stuff clean. > > But IMHO that's not a good reason to reject, especially with someone that's > planning to test this regularly (and presumably send fixes regularly).
Thanks, pushed as r15-6666-gf56bca0bbae762. Yes, I intend to share test results, and will try to fix regressions. That would be a good opportunity for me to get to know the RISC-V backend. Regards, Dimitar > > Jeff > >
