Hi PA,
(next try, for some reasons, my original email disappeared.)
Paul-Antoine Arras wrote:
Replying to your last two messages here and attaching revised patches.
Regarding the C++ and ME patches:
==> 0003-C-fix.patch <==
Subject: [PATCH 3/4] C++ fix
==> 0004-ME-fixes.patch <==
Subject: [PATCH 4/4] ME fixes
I think it is best to fold them into the Fortran patch; otherwise, they
would clearly need a better subject line.
And for both changes and in either case, both need a ChangeLog entry.
Additionally, the middle-end patch does not apply as it doesn't honor my
Dec 18 change to gimplify.cc.
* * *
==> 0001-OpenMP-Fortran-front-end-support-for-dispatch-adjust.patch <==
Subject: [PATCH 1/4] OpenMP: Fortran front-end support for dispatch +
adjust_args
The following two patches do not work (at least with some testsuite
testing) as in gcc/testsuite/ neither omp_lib nor libgomp.{so,a} is
available.
For gcc/testsuite/gfortran.dg/gomp/adjust-args-10.f90, you can just
remove the 'omp_lib'.
And as gcc/testsuite/gfortran.dg/gomp/declare-variant-21.f90 contains !
{ dg-do run }
... I'd suggest to move it to libgomp (including its aux-21.f90 file).
For adjust-args-10.f90, I wonder whether it is sufficient as
compile-time only or whether it makes more sense to have a "dg-do run"
to check that type(C_ptr) value vs. not-value works. I think either is
fine, but if it stays in gcc/, can you manually run it once to re-check
that it works? (I think I did check it and it worked.)
* * *
Note that gcc/testsuite/gfortran.dg/gomp/adjust-args-9.f90 and
...-10.f90 are missing a ChangeLog entry.
Likewise for dispatch-9a.f90.
BTW: If you have applied (committed) the patch locally, run
./contrib/gcc-changelog/git_check_commit.py -v -p — the '-v' will output
new files that have not been listed as warning and -p shows the patch
log for checking it. Additionally, it has the usual "git push" checks of
GCC.
* * *
Otherwise, LGTM. Thanks!
[As gimplify.cc couldn't be applied, I have not played with the patch
but I believe that it should be okay, based on past playing and looking
at the patch.]
Tobias
PS: Besides fixing the minor issues above, I think you have a
follow-up/cleanup patch available addressing some issues related to the
C/C++ FE, including where the '#pragma' is handled etc. I am looking
forward to that follow-up patch as well :-)
