On Wed, Nov 27, 2024 at 8:56 AM Richard Biener <richard.guent...@gmail.com> wrote: > > On Sun, Nov 3, 2024 at 11:28 PM Lewis Hyatt <lhy...@gmail.com> wrote: > > > > Several of the selftests in diagnostic-show-locus.cc and input.cc are > > sensitive to linemap internals. Adjust them here so they will support 64-bit > > location_t if configured. > > > > Likewise, handle 64-bit location_t in the support for > > -fdump-internal-locations. As was done with the analyzer, convert to > > (unsigned long long) explicitly so that 32- and 64-bit can be handled with > > the same printf formats. > > I was hoping David would have a look here. Absent from comments from him > this is OK when all else is approved and after giving him another week. > > What's missing review now? I've lost track ... > > Thanks, > Richard. >
Thanks, sounds good. This is pretty much the last one to review from v2 other than the final patch that switches over to 64-bit (in v2, # 14/14 https://gcc.gnu.org/pipermail/gcc-patches/2024-November/669161.html). That could probably wait for v3... I am planning to send out a v3 series soon that addresses your comments and has some new patches in response. I have already been pushing the patches that were acked and that don't introduce any functional changes, so v3 will not contain a lot of duplication, but I'll indicate there which ones need to be reviewed still. The main new ones are addressing the issue with reallocated gphi objects, there are three places which call loop_version() that can invalidate them and I have patches which address it, that I am about to test now. -Lewis
