On Tue, Nov 5, 2024 at 10:57 AM Jason Merrill <ja...@redhat.com> wrote: > > OK. > > On 11/3/24 5:22 PM, Lewis Hyatt wrote: > > The modules implementation is necessarily sensitive to the internal workings > > of class line_map, and so it needed changes in order to handle a 64-bit > > location_t. The changes mostly boil down to supporting that in the debug > > dumping routines (which is accomplished by using a new custom code %K for > > that purpose), and supporting that when streaming in and out from the > > module (which is accomplished by using a new loc() function to go along with > > existing abstractions like u() or z() for streaming in and out different > > data types).
Thank you for taking a look! I am going to push the other patch you acked (05/15) now since it is independent of everything else. This one for modules 10/15 is going to change slightly in v2, there was a request to eliminate the configurability and so this patch will only change by removing the #ifdef, since if we make this change it will be done unconditionally. I'll include this patch when I resend them, but probably there's no need to read through it again. Thanks! -Lewis