On Tue, 12 Nov 2024, Richard Sandiford wrote:
Evgeny Karpov <evgeny.kar...@microsoft.com> writes:
Hello,
Thank you for reviewing v2!
v3 addresses all comments on v2.
Changes in v3:
- Refactor implementation for the offset limit extension in
"symbol + offset" from 1MB to 16MB.
- Apply HOST_WIDE_INT_PRINT_UNSIGNED in ASM_OUTPUT_LOCAL.
- Exclude the "Disable the anchors" patch as it is not needed after
the offset limit refactoring.
- Exclude the "Handle alignment when it is bigger than BIGGEST_ALIGNMENT"
patch as it is not needed anymore when FFmpeg is compiled without LTO.
Also, the issue could be addressed in the FFmpeg package when LTO
is needed.
- Bypass hidden attribute warnings in MinGW until it is implemented.
Thanks for the update. As usual, I can only comment on the GCC internals,
without much knowledge of how mingw actually behaves. On that basis,
I've replied to two of the patches individually, but the series otherwise
looks good to me. OK for trunk with those changes if there are no objections
by noon UTC on Thursday.
No further objections from me on this version of the patchset, thanks for
the update!
// Martin
