On Sat, Nov 02, 2024 at 03:56:33PM -0400, James K. Lowden wrote:
> On Fri, 1 Nov 2024 20:27:21 +0100
> Jakub Jelinek <ja...@redhat.com> wrote:
>
> > the first patch should be like
> > https://gcc.gnu.org/r13-4588
> > or
> > https://gcc.gnu.org/r13-4589
> > adding support to contrib/gcc-changelog/git_commit.py
> > This commit should have a ChangeLog entry in the commit message, see
> > the above two commits for how they should look like.
>
> Thank you for your patience. It never occurred to me that I would make
> changes to contrib/ on the way to adding a front end.
That python file is (together with some others) sourced by our git pre-commit
hooks as well as by what the daily crontab job does to generate ChangeLog
file entries + DATESTAMP update.
> [snip]
> >From 95d8508ce8dabebbabfe14b9621fca45e2a397dddir.patch 4 Oct 2024 12:01:22
> >-0400
> From: "James K. Lowden" <jklow...@symas.com>
> Date: Sat 02 Nov 2024 12:51:49 PM EDT
> Subject: [PATCH] Add ChangeLog directories for cobol into git_commit.py.
>
> Prepare to add changelogs for the Cobol front end by changing
> the contrib git_commit.py script.
>
> contrib/ChangeLog:
>
> * gcc-changelog/git_commit.py (default_changelog_locations):
> New entry for gcc/cobol. New entry for libgcobol.
Dunno if your mailer ate the tabs at the start of the above 2 lines.
That is required so that it can be committed.
Otherwise LGTM, but please wait with it until everything else is approved
(unless that already happened).
Then this needs to be committed, you need to talk to us best on IRC or worst
case via mail, so that we can propagate that change to the pre-commit hooks,
and only when that is done commit the other patches.
>
> ---
> contrib/gcc-changelog/git_commit.py | ++
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/contrib/gcc-changelog/git_commit.py
> b/contrib/gcc-changelog/git_commit.py
> index 87ecb9e1a17..e9393012865 100755
> --- a/contrib/gcc-changelog/git_commit.py
> +++ b/contrib/gcc-changelog/git_commit.py
> @@ -39,6 +39,7 @@ default_changelog_locations = {
> 'gcc/c-family',
> 'gcc',
> 'gcc/cp',
> + 'gcc/cobol',
> 'gcc/d',
> 'gcc/fortran',
> 'gcc/go',
> @@ -66,6 +67,7 @@ default_changelog_locations = {
> 'libgcc',
> 'libgcc/config/avr/libf7',
> 'libgcc/config/libbid',
> + 'libgcobol',
> 'libgfortran',
> 'libgm2',
> 'libgomp',
Jakub
