On Fri, Nov 01, 2024 at 04:00:17PM -0400, Andrew MacLeod wrote:
> Maybe. The bitwise_and op1_range is very complicated.. I think its heavily
> used, so I would be surprised if it didn't. bitwise or was doing nothing
> at all and showed up immediately when I tried a few things. I think i just
> happned to hit it "lucky". It didnt fail any existing cases, just the ones
> I was trying to make more complicated.
>
> Do we want to port this to GCC14? Its pretty straightforward I think..
I think we want it on the trunk for a week or two first.
The reason for backporting is that it is a serious wrong-code and I think we
don't want to disable assume support altogether instead.
> mostly cosmetic changes due to Value_Range and difference in the range-query
> access to gori. Ive got it converted already, but noticed there are some
> failures on the gcc14 branch? ie, seems to be:
>
> FAIL: g++.dg/cpp23/attr-assume1.C -std=c++14 (test for excess errors)
> FAIL: g++.dg/cpp23/attr-assume1.C -std=c++17 (test for excess errors)
> FAIL: g++.dg/cpp23/attr-assume1.C -std=c++20 (test for excess errors)
> FAIL: g++.dg/cpp23/attr-assume3.C -std=c++14 (test for excess errors)
> FAIL: g++.dg/cpp23/attr-assume3.C -std=c++17 (test for excess errors)
> FAIL: g++.dg/cpp23/attr-assume3.C -std=c++20 (test for excess errors)
> FAIL: g++.dg/cpp23/attr-assume5.C -std=gnu++14 (test for excess errors)
> FAIL: g++.dg/cpp23/attr-assume5.C -std=gnu++17 (test for excess errors)
> FAIL: g++.dg/cpp23/attr-assume5.C -std=gnu++20 (test for excess errors)
> FAIL: g++.dg/cpp23/attr-assume6.C -std=gnu++14 (test for excess errors)
> FAIL: g++.dg/cpp23/attr-assume6.C -std=gnu++17 (test for excess errors)
> FAIL: g++.dg/cpp23/attr-assume6.C -std=gnu++20 (test for excess errors
That needs to be debugged and fixed before commiting, can help with that
next week if it is in some code I'm familiar with.
And important is what the excess errors are.
Jakub
