On Wed, 2024-10-30 at 17:33 +0000, Sam James wrote:
> Qing Zhao <qing.z...@oracle.com> writes:
>
> > > On Oct 30, 2024, at 10:48, David Malcolm <dmalc...@redhat.com>
> > > wrote:
> > >
> > > On Wed, 2024-10-30 at 14:34 +0000, Sam James wrote:
> > > > Qing Zhao <qing.z...@oracle.com> writes:
> > > >
> > > > > Control this with a new option -fdiagnostics-details.
> > > > >
> > > > > [...]
> > > >
> > > > The patch doesn't apply for me on very latest trunk -- I think
> > > > David's
> > > > recent diag refactoring means it needs a slight rebase. Could
> > > > you
> > > > send
> > > > that?
> > >
> > > If it's broken, it was probably by:
> > >
> > > r15-4610 ("Use unique_ptr in more places in
> > > pretty_printer/diagnostics
> > > [PR116613]")
> > > https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=bf43fe6aa966eaf397ea3b8ebd6408d3d124e285
> >
> > Yes, due to the following change in the above commit:
> >
> > diff --git a/gcc/toplev.cc b/gcc/toplev.cc
> > index
> > 62034c32b4aff32cdf2cb051bf9d0803b4730b3f..a12a2e1afba15ba16f6ade624
> > cde3e60907ba5d2 100644 (file)
> > --- a/gcc/toplev.cc
> > +++ b/gcc/toplev.cc
> > @@ -42,6 +42,7 @@ along with GCC; see the file COPYING3. If not
> > see
> > #include "cgraph.h"
> > #include "coverage.h"
> > #include "diagnostic.h"
> > +#include "pretty-print-urlifier.h"
> > #include "varasm.h"
> > #include "tree-inline.h"
> > #include "realmpfr.h" /* For GMP/MPFR/MPC versions, in
> > print_version. */
> >
> >
> > [...]
> > >
>
> To continue testing, I am using the attached hacked up patches
Thanks; FWIW the fixes in those patches look correct to me.
Dave
