On Wed, 2024-10-30 at 14:34 +0000, Sam James wrote: > Qing Zhao <qing.z...@oracle.com> writes: > > > Control this with a new option -fdiagnostics-details. > > > > [...] > > The patch doesn't apply for me on very latest trunk -- I think > David's > recent diag refactoring means it needs a slight rebase. Could you > send > that?
If it's broken, it was probably by: r15-4610 ("Use unique_ptr in more places in pretty_printer/diagnostics [PR116613]") https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=bf43fe6aa966eaf397ea3b8ebd6408d3d124e285 and/orĀ r15-4617 ("analyzer: avoid implicit use of global_dc's pretty_printer [PR116613]") https://gcc.gnu.org/pipermail/gcc-patches/2024-October/666390.html which both made small changes to the internal interface for creating events in a diagnostic path, and possibly by: r15-4760 ("diagnostics: support multiple output formats simultaneously [PR116613]") https://gcc.gnu.org/pipermail/gcc-patches/2024-October/666807.html which made big changes to diagnostic_context internally. Sorry about this; let me know if you want help debugging/fixing things. Dave