> Nit, space before '('. > LGTM with that fixed and once the middle-end changes are in.
Got it, thanks Robin. Pan -----Original Message----- From: Robin Dapp <rdapp....@gmail.com> Sent: Friday, October 25, 2024 11:56 PM To: Li, Pan2 <pan2...@intel.com>; gcc-patches@gcc.gnu.org Cc: richard.guent...@gmail.com; tamar.christ...@arm.com; juzhe.zh...@rivai.ai; kito.ch...@gmail.com; jeffreya...@gmail.com; Robin Dapp <rdapp....@gmail.com> Subject: Re: [PATCH 4/5] RISC-V: Implement the MASK_LEN_STRIDED_LOAD{STORE} > +(define_expand "mask_len_strided_store_<mode>" > + [(match_operand 0 "pmode_reg_or_0_operand") > + (match_operand 1 "pmode_reg_or_0_operand") > + (match_operand:V 2 "register_operand") > + (match_operand:<VM> 3 "vector_mask_operand") > + (match_operand 4 "autovec_length_operand") > + (match_operand 5 "const_0_operand")] > + "TARGET_VECTOR" > + { > + riscv_vector::expand_strided_store(<MODE>mode, operands); Nit, space before '('. LGTM with that fixed and once the middle-end changes are in. -- Regards Robin