Jakub Jelinek <ja...@redhat.com> writes:
> On Fri, Oct 25, 2024 at 01:25:25PM +0200, Arsen Arsenović wrote:
>> Maybe we should go the other way around? Compressing eight spaces into
>> a tab leads to strange artifacts in diffs (where lines appear
>> misindented because some were aligned by tabs and some by spaces), and
>> nowadays editor authors seem to have forgotten tabs are eight spaces and
>> instead default to (or, worse, hard-code) four, obviously making the
>> codebase quite unreadable. We also don't get the benefit of being able
>> to adjust tabstop locally to our preferences when we use two-column
>> indentation, so I don't see an advantage to keeping 'indent-tabs-mode
>> (or equivalent in other editors) enabled.
>
> Editors which are worth a dime handle tabs fine, and I think using tabs is
> better.
> Changing to space would be a major obstackle in git blame/git archeology,
> something lots of people use very often.
IMO these (already-committed other) whitespace changes mean we should
already consider a .git-blame-ignore-revs file at the root of the repo.
We would list any large whitespace changes in there.
Users would have to run 'git config blame.ignoreRevsFile
.git-blame-ignore-revs' unfortunately though.
I believe we should do this regardless of which direction we go in wrt tab.
> Admittely even this patch which changes 40860 lines isn't very nice, but
> if we had to change 1219139 lines instead (still talking just about
> gcc/, include/, lib{gcc,cpp,iberty,stdc++-v3})...
>
> Jakub
thanks,
sam
