On Fri, 25 Oct 2024 at 12:17, Jakub Jelinek <ja...@redhat.com> wrote:
>
> Hi!
>
> On top of the previously posted leading whitespace patch, this change
> just replaces 8 consecutive spaces in leading whitespace by tab.
> The patch is too large (1MB xz -9e compressed), so I'm not even trying to
> split it up into 4+ pieces to fit under the mailing list limits.
> But the change was done purely by a script,
> for i in `find gcc -name \*.h -o -name \*.cc -o -name \*.c | grep -v
> testsuite/ | grep -v gofrontend/`; do grep -l '^[ ]* ' $i; done >
> /tmp/2
> grep -L 'do not edit' `cat /tmp/2` > /tmp/3
> for i in `find include lib{iberty,gcc,cpp,stdc++-v3} -name \*.h -o -name
> \*.cc -o -name \*.c | grep -v testsuite/ | grep -v gofrontend/`; do grep -l
> '^[ ]* ' $i; done >> /tmp/3
> for j in `seq 32`; do for i in `cat /tmp/3`; do sed -i -e 's/^\(\t*\)
> /\1\t/g' $i; done; done
> diff -upb yields nothing.
>
> Ok for trunk if this passes bootstrap/regtest?
>
> 2024-10-25 Jakub Jelinek <ja...@redhat.com>
>
> libstdc++-v3/
> * doc/doxygen/stdheader.cc: Replace 8 spaces with tab in leading
> whitespace.
> * config/os/aix/ctype_inline.h: Likewise.
> * config/locale/newlib/ctype_members.cc: Likewise.
> * config/locale/dragonfly/monetary_members.cc: Likewise.
> * config/locale/dragonfly/ctype_members.cc: Likewise.
> * config/locale/gnu/monetary_members.cc: Likewise.
> * config/locale/gnu/ctype_members.cc: Likewise.
> * config/locale/generic/ctype_members.cc: Likewise.
> * config/locale/darwin/ctype_members.cc: Likewise.
> * config/cpu/i486/opt/bits/opt_random.h: Likewise.
> * include/debug/functions.h: Likewise.
> * include/debug/map.h: Likewise.
> * include/debug/formatter.h: Likewise.
> * include/debug/safe_iterator.h: Likewise.
> * include/parallel/types.h: Likewise.
> * include/parallel/sort.h: Likewise.
> * include/parallel/algorithmfwd.h: Likewise.
> * include/parallel/numericfwd.h: Likewise.
> * include/parallel/unique_copy.h: Likewise.
> * include/parallel/for_each.h: Likewise.
> * include/parallel/partition.h: Likewise.
> * include/parallel/multiway_merge.h: Likewise.
> * include/parallel/losertree.h: Likewise.
> * include/parallel/queue.h: Likewise.
> * include/parallel/workstealing.h: Likewise.
> * include/parallel/tags.h: Likewise.
> * include/parallel/omp_loop_static.h: Likewise.
> * include/parallel/partial_sum.h: Likewise.
> * include/parallel/list_partition.h: Likewise.
> * include/parallel/iterator.h: Likewise.
> * include/parallel/set_operations.h: Likewise.
> * include/parallel/equally_split.h: Likewise.
> * include/parallel/multiway_mergesort.h: Likewise.
> * include/parallel/random_shuffle.h: Likewise.
> * include/parallel/base.h: Likewise.
> * include/parallel/omp_loop.h: Likewise.
> * include/parallel/settings.h: Likewise.
> * include/parallel/algobase.h: Likewise.
> * include/parallel/checkers.h: Likewise.
> * include/parallel/find.h: Likewise.
> * include/parallel/for_each_selectors.h: Likewise.
> * include/parallel/search.h: Likewise.
> * include/parallel/multiseq_selection.h: Likewise.
> * include/parallel/merge.h: Likewise.
> * include/parallel/random_number.h: Likewise.
> * include/parallel/quicksort.h: Likewise.
> * include/parallel/find_selectors.h: Likewise.
> * include/parallel/balanced_quicksort.h: Likewise.
> * include/bits/random.h: Likewise.
> * include/bits/stl_construct.h: Likewise.
> * include/bits/valarray_after.h: Likewise.
> * include/bits/stl_uninitialized.h: Likewise.
> * include/bits/shared_ptr_base.h: Likewise.
> * include/bits/unique_ptr.h: Likewise.
> * include/bits/stl_pair.h: Likewise.
> * include/bits/stringfwd.h: Likewise.
> * include/bits/stl_iterator.h: Likewise.
> * include/bits/atomic_base.h: Likewise.
> * include/bits/valarray_array.h: Likewise.
> * include/bits/stl_vector.h: Likewise.
> * include/bits/fs_dir.h: Likewise.
> * include/bits/shared_ptr.h: Likewise.
> * include/bits/char_traits.h: Likewise.
> * include/bits/stream_iterator.h: Likewise.
> * include/bits/predefined_ops.h: Likewise.
> * include/bits/basic_string.h: Likewise.
> * include/bits/concept_check.h: Likewise.
> * include/bits/stl_iterator_base_types.h: Likewise.
> * include/bits/enable_special_members.h: Likewise.
> * include/bits/locale_classes.h: Likewise.
> * include/bits/stl_tempbuf.h: Likewise.
> * include/bits/ptr_traits.h: Likewise.
> * include/bits/stl_algo.h: Likewise.
> * include/bits/stl_function.h: Likewise.
> * include/bits/alloc_traits.h: Likewise.
> * include/bits/uniform_int_dist.h: Likewise.
> * include/bits/slice_array.h: Likewise.
> * include/bits/unordered_map.h: Likewise.
> * include/bits/stl_bvector.h: Likewise.
> * include/bits/gslice_array.h: Likewise.
> * include/bits/basic_ios.h: Likewise.
> * include/bits/move.h: Likewise.
> * include/bits/stl_numeric.h: Likewise.
> * include/bits/unordered_set.h: Likewise.
> * include/bits/boost_concept_check.h: Likewise.
> * include/bits/ios_base.h: Likewise.
> * include/bits/uses_allocator.h: Likewise.
> * include/bits/mask_array.h: Likewise.
> * include/bits/stl_iterator_base_funcs.h: Likewise.
> * include/bits/locale_facets_nonio.h: Likewise.
> * include/bits/stl_multiset.h: Likewise.
> * include/tr1/random.h: Likewise.
> * include/tr1/functional_hash.h: Likewise.
> * include/tr1/special_function_util.h: Likewise.
> * include/tr1/shared_ptr.h: Likewise.
> * include/tr1/hashtable_policy.h: Likewise.
> * include/ext/bitmap_allocator.h: Likewise.
> * include/ext/vstring_fwd.h: Likewise.
> * include/ext/codecvt_specializations.h: Likewise.
> * include/ext/pointer.h: Likewise.
> * include/ext/mt_allocator.h: Likewise.
> * include/ext/aligned_buffer.h: Likewise.
> * include/ext/type_traits.h: Likewise.
> * include/ext/malloc_allocator.h: Likewise.
> * include/ext/pod_char_traits.h: Likewise.
> * include/ext/debug_allocator.h: Likewise.
> * include/ext/extptr_allocator.h: Likewise.
> * include/ext/throw_allocator.h: Likewise.
> * include/ext/vstring.h: Likewise.
> * include/ext/pool_allocator.h: Likewise.
> * include/ext/sso_string_base.h: Likewise.
> * include/ext/ropeimpl.h: Likewise.
> * include/experimental/bits/fs_path.h: Likewise.
> * include/experimental/bits/fs_dir.h: Likewise.
> * include/experimental/bits/shared_ptr.h: Likewise.
> * include/experimental/bits/simd_math.h: Likewise.
Everything in libstdc++-v3 above here is OK.
> * include/pstl/numeric_impl.h: Likewise.
> * include/pstl/glue_numeric_impl.h: Likewise.
> * include/pstl/glue_memory_impl.h: Likewise.
> * include/pstl/parallel_backend_tbb.h: Likewise.
> * include/pstl/glue_algorithm_impl.h: Likewise.
> * include/pstl/parallel_impl.h: Likewise.
> * include/pstl/parallel_backend_utils.h: Likewise.
> * include/pstl/memory_impl.h: Likewise.
> * include/pstl/parallel_backend_serial.h: Likewise.
> * include/pstl/execution_impl.h: Likewise.
> * include/pstl/algorithm_fwd.h: Likewise.
> * include/pstl/execution_defs.h: Likewise.
> * include/pstl/pstl_config.h: Likewise.
> * include/pstl/algorithm_impl.h: Likewise.
> * include/pstl/utils.h: Likewise.
> * include/pstl/numeric_fwd.h: Likewise.
> * include/pstl/glue_numeric_defs.h: Likewise.
> * include/pstl/unseq_backend_simd.h: Likewise.
> * include/pstl/glue_algorithm_defs.h: Likewise.
include/pstl contains code imported from elsewhere, so please don't
change for now. We can send patches upstream to get them to fix this
(either using spaces or tabs consistently, not tabs after spaces!).
> * include/backward/auto_ptr.h: Likewise.
> * include/backward/hashtable.h: Likewise.
These backward headers are OK.
> * src/c++98/compatibility.cc: Likewise.
> * src/c++98/istream.cc: Likewise.
> * src/c++98/misc-inst.cc: Likewise.
> * src/c++98/ios_init.cc: Likewise.
> * src/c++98/tree.cc: Likewise.
> * src/c++98/valarray.cc: Likewise.
> * src/c++98/complex_io.cc: Likewise.
> * src/c++98/concept-inst.cc: Likewise.
> * src/c++98/codecvt.cc: Likewise.
> * src/c++98/locale_facets.cc: Likewise.
> * src/c++98/locale.cc: Likewise.
> * src/c++98/istream-string.cc: Likewise.
> * src/filesystem/dir.cc: Likewise.
> * src/filesystem/path.cc: Likewise.
src/c++98 and src/filesytem changes are OK.
> * src/c++17/ryu/d2fixed.c: Likewise.
> * src/c++17/ryu/d2s.c: Likewise.
> * src/c++17/ryu/generic_128.c: Likewise.
> * src/c++17/ryu/f2s.c: Likewise.
ryu is imported from elsewhere, let's not change it.
> * src/c++17/fs_path.cc: Likewise.
> * src/c++17/fs_dir.cc: Likewise.
OK to change
> * src/c++17/fast_float/fast_float.h: Likewise.
This comes from upstream, I'll send a pull request (they already
accepted my fix for the python script that generates this header, to
avoid trailing whitespace).
> * src/c++11/ios_errcat.cc: Likewise.
> * src/c++11/sso_string.cc: Likewise.
> * src/c++11/localename.cc: Likewise.
> * src/c++11/debug.cc: Likewise.
> * src/c++11/cow-stdexcept.cc: Likewise.
> * src/c++11/shared_ptr.cc: Likewise.
> * src/c++11/future.cc: Likewise.
> * src/c++11/compatibility-ldbl-alt128.cc: Likewise.
> * src/c++11/codecvt.cc: Likewise.
> * src/c++11/locale_init.cc: Likewise.
src/c++11 changes are OK.
> * libsupc++/pointer_type_info.cc: Likewise.
> * libsupc++/dyncast.cc: Likewise.
> * libsupc++/cxxabi_init_exception.h: Likewise.
> * libsupc++/tinfo.h: Likewise.
> * libsupc++/exception_ptr.h: Likewise.
> * libsupc++/si_class_type_info.cc: Likewise.
> * libsupc++/vmi_class_type_info.cc: Likewise.
> * libsupc++/vterminate.cc: Likewise.
> * libsupc++/guard.cc: Likewise.
> * libsupc++/eh_type.cc: Likewise.
> * libsupc++/eh_personality.cc: Likewise.
> * libsupc++/eh_ptr.cc: Likewise.
> * libsupc++/pbase_type_info.cc: Likewise.
> * libsupc++/class_type_info.cc: Likewise.
> * libsupc++/pmem_type_info.cc: Likewise.
libsupc++ changes are OK.
So everything except:
include/pstl/*
src/c++17/ryu/*
src/c++17/fast_float/*
Thanks!
