在 2024/8/5 22:15, Jeff Law 写道:


On 8/4/24 8:20 PM, Jiawei wrote:

在 2024/8/5 8:45, Jeff Law 写道:


On 8/2/24 9:32 AM, Jiawei wrote:
https://github.com/riscv/riscv-isa-manual/blob/main/src/zimop.adoc

gcc/ChangeLog:

    * common/config/riscv/riscv-common.cc: New extension.
    * config/riscv/riscv.opt: New mask.

gcc/testsuite/ChangeLog:

    * gcc.target/riscv/arch-42.c: New test.
    * gcc.target/riscv/arch-43.c: New test.
Shouldn't the binutils bits go in first?  There's basic support for Zimop/Zcmop from Lyut on the binutils list in late 2023 or early 2024. I'm pretty sure it marked as DO NOT MERGE because we were waiting for the extension to get ratified.

Christoph informed me that Zimop has been ratified, so we may not need to worry about the spec lifecycle status:

https://jira.riscv.org/browse/RVS-1603?src=confmacro
Agreed.  No concerns about spec lifecycle at this point.



I don't know if Lyut is doing any RISC-V work right now, so if you wanted to ping the patch on his behalf, it'd be appreciated and I can handle the review on the binutils side too.

I found that ESWIN's patch to support Zimop on the binutils mailing list last month:

https://sourceware.org/pipermail/binutils/2024-June/134592.html
I don't watch binutils as closely as perhaps I should.

That patch looks marginally better than Lyut's version.  It has the updated version #s for the spec and handles the implied extensions. Let's go with Xiao's version.

Xiao, the Zimop/Zcmop patches are OK for binutils.

Jiawei, the GCC patches are OK once Xiao pushes his changes to the binutils repo.  Alternately if you have permissions in the binutils repo, you can push them for Xiao.

Jeff

Thanks Jeff! I think I do not have the permissions in the binutils repo, let me contact Nelson to ask him give  some help.


BR,

Jiawei

Reply via email to